[FIXED]Sound issues

[Squall Leonhart]

volume could be set to shift+ / shift -

[bgK]

I think that would cause problems with some keymaps.

On my keyboard (french azerty), the plus key is accessed using shift+= while the minus key is accessed directly using - (on the same key as the 6).

[chrono]

SDL sound patch

Â

NUMPAD /: decrease volume

NUMPAD *: increase volume

Â

TODO: gb sound effects (surround, echo, stereo)

[bgK]

Thanks for your patch, however it doesn't apply correctly as of rev 649. Can you please update it ?

[chrono]

SDL sound patch for v649

[bgK]

Thanks. This is now rev 650.

Though I'm not totally satisfied with the numpad * / shortcuts. What about the laptops users ? Can't we find better shortcuts ? I was thinking of page up / down ...

[KunaiTeam]

It doesn't personally affect me, but I just thought I would point out that some laptop keyboards lack page up/down buttons as well.

Â

IIRC, the only safe US laptop keys are the numbers, the letters, the function keys, the spacebar, backspace, ESC, tab, shift, caps lock, control, option, meta, and the basic punctuation. I don't know about international keyboards.

[slacker]

f1 and f2 was only so i could test them on the fly they were not used in the list so i thought id just leave them in. anyway the patch shouldve saved you some time atleast.

[bgK]

The F1 and F2 keys are used if you look carefully at the code. It's the switch falltrough thingy.

Â

But yeah, everybody here did a great job to quickly fix the SDL port by submitting patches. Thanks again.

[spacy51]

Yes, I'd never expect to see reactions that fast [img]<fileStore.core_Emoticons>/emoticons/smile.png[/img]/emoticons/[email protected] 2x" width="20" height="20" />